This repository has been archived by the owner on Feb 2, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding statistics SummaryCards component #50
Adding statistics SummaryCards component #50
Changes from all commits
c7bf5b2
66d9126
c888621
0ea42a8
942eeef
7f780ea
477448f
d5e173c
2d93399
8a0a585
900509d
ad4698d
fd53370
5e5bd86
64b47aa
8497f33
5d389fc
ce1b42f
d15d6b9
0c5260d
0e02d5c
c94978b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more thing about the shape of the data.
Usually it's not a good idea to work with floats in JS and also if working with big numbers JS
number
type won't be able to handle it.Having said that, it might not be a problem for this use case as:
number
limitSo, keep that in mind for the future, but does not need necessarily to change anything at this point
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I have it in mind! I would think they come as a string and may need to be formatted, but we can define it in #40 when integrating the SDK.