This repository has been archived by the owner on Feb 2, 2024. It is now read-only.
abort setState when our component unmount #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
henrypalacios
commented
Jun 24, 2022
|
|
||
| const executedSellAmount = order?.executedSellAmount.toString() | ||
| const executedBuyAmount = order?.executedBuyAmount.toString() | ||
| useEffect(() => { | ||
| if (!networkId || !order?.uid) { | ||
| return | ||
| } | ||
| const controller = new AbortController() |
There was a problem hiding this comment.
@ramirotw we could use a simple boolean (canceled = false) variable here as well, but AbortController seems more appropriate.
|
Good catch 👍 |
matextrem
approved these changes
Jun 24, 2022
ramirotw
approved these changes
Jun 24, 2022
ramirotw
pushed a commit
that referenced
this pull request
Jun 28, 2022
ramirotw
added a commit
that referenced
this pull request
Jun 29, 2022
* bump cow-sdk * fix missing prod/barn responses merge * abort setState when our component unmount (#145) * re-run tokens fetch if network changes while there's an in-flight request * disable env merge for getAccountOrders * fix order search in different networks Co-authored-by: Henry Palacios <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #138
Avoid Race condition when send request with
currentNetworkUsing AbortController web request.