Skip to content
This repository has been archived by the owner on Feb 2, 2024. It is now read-only.

Increase column, show dash and use tooltip mobile #113

Merged
merged 6 commits into from
Jun 14, 2022
Merged

Increase column, show dash and use tooltip mobile #113

merged 6 commits into from
Jun 14, 2022

Conversation

henrypalacios
Copy link
Contributor

@henrypalacios henrypalacios commented Jun 8, 2022 •
edited
Loading

Summary

Closes #109

  • Expand the column to show the value in 1 line
  • Show 'dash' or so when there is no value in the column on mobile view
  • Display whole surplus amount on hover in a mobile view

To Test

Open tx https://pr113--explorer.review.gnosisdev.com/gc/address/0x2dB8323b3766b868AAF6a967E55eEb35C233DE9d

@henrypalacios henrypalacios self-assigned this Jun 8, 2022
@coveralls
Copy link

coveralls commented Jun 8, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2469739539

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 17 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 43.872%
Files with Coverage Reduction New Missed Lines %
src/const.ts 17 81.51%
Totals Coverage Status
Change from base Build 2437563327: -0.2%
Covered Lines: 2162
Relevant Lines: 4177
💛 - Coveralls

@github-actions
Copy link

github-actions bot commented Jun 8, 2022

@elena-zh
Copy link

elena-zh commented Jun 8, 2022

Hi @henrypalacios , great changes!
I wonder if we could add a dash to the Surplus column when it is empty in a desktop version.
WDYT?

Thanks!

ramirotw
ramirotw approved these changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@ramirotw ramirotw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@henrypalacios
Copy link
Contributor Author

Now that I see it again with the dash, it looks weird to me 😅

How do you think we can improve it @alongoni?

alongoni
alongoni approved these changes Jun 9, 2022
View reviewed changes
Copy link
Contributor

@alongoni alongoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!!!

elena-zh
elena-zh approved these changes Jun 9, 2022
View reviewed changes
Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ramirotw ramirotw requested a review from alfetopito June 14, 2022 12:18
@henrypalacios henrypalacios merged commit 8255566 into develop Jun 14, 2022
@henrypalacios henrypalacios deleted the 109-surplus-column branch June 14, 2022 12:34
@henrypalacios henrypalacios mentioned this pull request Jun 23, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@elena-zh elena-zh elena-zh approved these changes

@ramirotw ramirotw ramirotw approved these changes

@alongoni alongoni alongoni approved these changes

@anxolin anxolin Awaiting requested review from anxolin

@alfetopito alfetopito Awaiting requested review from alfetopito

Assignees

@henrypalacios henrypalacios

Labels
app:Explorer Explorer App
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI issues related to the Surplus column
5 participants
@henrypalacios @coveralls @elena-zh @alongoni @ramirotw