-
Notifications
You must be signed in to change notification settings - Fork 8
[Batch Viewer] Zoom and drag improvements #103
Conversation
Pull Request Test Coverage Report for Build 2437367374Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
|
@alongoni I'm comparing the same tx in the preview app as well as in barn and both look identical, why is that? Barn (should have the issue): https://barn.explorer.cow.fi/tx/0xc2eb04b549d68c770062591e2561c5b1534ea665c6179d33a779c52376c9161d?tab=graph |
hey @ramirotw. Yes, they look identical, but in this PR we prevent the nodes overlapping when a user moves a node over other. |
thanks for the video! |
regarding point 1) of #42 |
I tried something to deal with this but it doesn't work so well. It effectively causes a conflict with the zoom 😆 @alongoni while I was trying to build something I came across this cytoscape-automove, it could be used to solved that point. I think we should move on and leave it as a low priority. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be mitigated by the addition of the reset button (#100). I think if we don't allow moving the nodes outside the BV area, it could cause a conflict with the zoom. WDYT @ramirotw @henrypalacios @elena-zh
Agreed @alongoni.
Nice work!
Looks good to me even with elements outside the frame, due to now we have a Reset button that can return the diagram to the default state. |
Summary
Closes #42
To Test