Skip to content
This repository has been archived by the owner on Feb 2, 2024. It is now read-only.

[Batch Viewer] Zoom and drag improvements #103

Merged
merged 5 commits into from
Jun 3, 2022

Conversation

alongoni
Copy link
Contributor

@alongoni alongoni commented May 27, 2022

Summary

Closes #42

To Test

  1. <> Open the batch viewer

@alongoni alongoni self-assigned this May 27, 2022
@alongoni alongoni added app:Explorer Explorer App Medium Protofire Bug Something isn't working labels May 27, 2022
@coveralls
Copy link

coveralls commented May 27, 2022

Pull Request Test Coverage Report for Build 2437367374

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 44.121%

Totals Coverage Status
Change from base Build 2437175687: 0.0%
Covered Lines: 2172
Relevant Lines: 4190

💛 - Coveralls

@github-actions
Copy link

@ramirotw
Copy link
Contributor

ramirotw commented Jun 1, 2022

@alongoni I'm comparing the same tx in the preview app as well as in barn and both look identical, why is that?

Preview app: https://pr103--explorer.review.gnosisdev.com/tx/0xc2eb04b549d68c770062591e2561c5b1534ea665c6179d33a779c52376c9161d/?tab=graph

Barn (should have the issue): https://barn.explorer.cow.fi/tx/0xc2eb04b549d68c770062591e2561c5b1534ea665c6179d33a779c52376c9161d?tab=graph

image

image

@alongoni
Copy link
Contributor Author

alongoni commented Jun 1, 2022

@alongoni I'm comparing the same tx in the preview app as well as in barn and both look identical, why is that?

Preview app: https://pr103--explorer.review.gnosisdev.com/tx/0xc2eb04b549d68c770062591e2561c5b1534ea665c6179d33a779c52376c9161d/?tab=graph

Barn (should have the issue): https://barn.explorer.cow.fi/tx/0xc2eb04b549d68c770062591e2561c5b1534ea665c6179d33a779c52376c9161d?tab=graph

hey @ramirotw. Yes, they look identical, but in this PR we prevent the nodes overlapping when a user moves a node over other.
https://www.loom.com/share/62e1b73daae34155beb9248460851be0

@ramirotw
Copy link
Contributor

ramirotw commented Jun 1, 2022

thanks for the video!

@alongoni
Copy link
Contributor Author

alongoni commented Jun 1, 2022

regarding point 1) of #42
image
This will be mitigated by the addition of the reset button (#100). I think if we don't allow moving the nodes outside the BV area, it could cause a conflict with the zoom. WDYT @ramirotw @henrypalacios @elena-zh

@alongoni alongoni marked this pull request as ready for review June 1, 2022 17:52
@henrypalacios
Copy link
Contributor

I tried something to deal with this but it doesn't work so well. It effectively causes a conflict with the zoom 😆

@alongoni while I was trying to build something I came across this cytoscape-automove, it could be used to solved that point.

I think we should move on and leave it as a low priority.

@ramirotw ramirotw requested a review from alfetopito June 3, 2022 10:31
Copy link
Contributor

@ramirotw ramirotw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be mitigated by the addition of the reset button (#100). I think if we don't allow moving the nodes outside the BV area, it could cause a conflict with the zoom. WDYT @ramirotw @henrypalacios @elena-zh

Agreed @alongoni.

Nice work!

@henrypalacios henrypalacios merged commit 0168e51 into develop Jun 3, 2022
@henrypalacios henrypalacios deleted the 42-zoom-drag-issues-BV branch June 3, 2022 23:06
@elena-zh
Copy link

elena-zh commented Jun 7, 2022

Looks good to me even with elements outside the frame, due to now we have a Reset button that can return the diagram to the default state.

@henrypalacios henrypalacios mentioned this pull request Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
app:Explorer Explorer App Bug Something isn't working Medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with zooming/dragging and dropping elements on a Batch viewer diagram
6 participants