Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SENTRY] Add chainId tag and user to context #751

Merged
merged 10 commits into from
Jun 29, 2022
Merged

[SENTRY] Add chainId tag and user to context #751

merged 10 commits into from
Jun 29, 2022

Conversation

W3stside
Copy link
Contributor

@W3stside W3stside commented Jun 27, 2022 •
edited
Loading

Summary

This pr adds:

  1. scoped tag chainId which can be filtered for in Sentry
  2. user address (confirmed ok by Anna)
  3. updates Sentry to v7 (from 6) changes v6 to v7 sentry

Example of this in an issue can be seen here - sentry

follow up to this will be creating alerts for chains 1 and 100 mainly, with 4 being mostly silenced / phased out

screenshot (look at the tags section, 3rd one on top)

image

regarding double errors in local:
image

@W3stside W3stside requested review from a team June 27, 2022 20:11
@github-actions
Copy link
Contributor

CLA Assistant Lite All Contributors have signed the CLA.

@W3stside W3stside changed the title Sentry update 06 2022 [SENTRY] Add chainId tag and user to context Jun 27, 2022
@github-actions
Copy link
Contributor

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

@elena-zh
Copy link

Hey @W3stside , changes GTM!
The only one question is that we have different columns showing events for this or that type of error in Senty. Is this OK?
chain insuff balance
events 0 insuff liquidity
events unsupp token
price error

@W3stside
Copy link
Contributor Author

Hey @W3stside , changes GTM! The only one question is that we have different columns showing events for this or that type of error in Senty. Is this OK? chain insuff balance events 0 insuff liquidity events unsupp token price error

it's ok, some of the issues are not being properly tagged from changes I'm making on my side during testing

@W3stside W3stside added the SENTRY all thing sentry upgrade related label Jun 28, 2022
alfetopito
alfetopito reviewed Jun 28, 2022
View reviewed changes
src/custom/state/sentry/updater/index.ts Outdated Show resolved Hide resolved
src/custom/state/sentry/updater/index.ts Outdated Show resolved Hide resolved
src/custom/state/sentry/updater/index.ts Outdated Show resolved Hide resolved
@W3stside W3stside requested review from alfetopito and nenadV91 June 29, 2022 09:19
anxolin
anxolin reviewed Jun 29, 2022
View reviewed changes
Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments, other than that is an approve

src/custom/state/sentry/updater/index.ts Outdated Show resolved Hide resolved
src/custom/state/sentry/updater/index.ts Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
src/custom/state/sentry/updater/index.ts Outdated Show resolved Hide resolved
src/custom/state/sentry/updater/index.ts Show resolved Hide resolved
nenadV91
nenadV91 approved these changes Jun 29, 2022
View reviewed changes
Copy link
Contributor

@nenadV91 nenadV91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from a small comment LGTM

@W3stside W3stside mentioned this pull request Jun 29, 2022
Merged
@W3stside W3stside merged commit b285c2a into develop Jun 29, 2022
@W3stside W3stside deleted the sentry-update-06-2022 branch June 29, 2022 14:20
@github-actions github-actions bot locked and limited conversation to collaborators Jun 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anxolin anxolin anxolin left review comments

@elena-zh elena-zh elena-zh approved these changes

@nenadV91 nenadV91 nenadV91 approved these changes

@alfetopito alfetopito Awaiting requested review from alfetopito

Assignees
No one assigned
Labels
SENTRY all thing sentry upgrade related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@W3stside @elena-zh @alfetopito @anxolin @nenadV91