Refactor Menu

[anxolin]

Summary

@fairlighteth instead of adding a lot of feedback in your PR I preferred to reiterate in your PR and document exactly what I changed and why. Sorry if it's too detailed

This PR is an attempt to refactor and cleanup further of #707

The logic is maintained, but I just rewrote all types, and restructure the code to try to make it more maintainable.

Some of the changes in style were:

• Changed many names.
  • Components must start with capital letter
  • This get functions are in reality a component. So they also should be capitalised.
    i.e before , after )
  • We use a naming convention for the props <Name-of-component>Props. For example before , after
• Logic was still a bit overcomplicated. i.e. before, after
• Drill down props were encapsulated in an object, so the props can be simpler, and is easier to drill down the props. i.e. before before, after

Also MAIN_MENU_TYPE because is a type shouldn't be written in all capitals. It was also broken down to be able to define more semantic types and reuse for both the data definition and the components. For example, now the new types can be both be used in the data definition (so they are checked), and also in they components, like this DropDown can receive a DropDownItem and render.

Breaking down the types also allowed to model as mandatory some fields that before where optional i.e. this title is not optional anymore.

The external/internal logic is better handled, instead of relying on a boolean and then adding this logic which can be complex to follow, because reports duplicated fields like onClick and onClickOptional. Now relies in types so representing the internal/external link is simpler.

A similar thing was done for the Dark Mode button. Instead of relying on some String action which makes the component too hard to maintain, we rely on types so rendering this special link is simple

[github-actions]

CLA Assistant Lite All Contributors have signed the CLA.

[github-actions]

• 🔭 GP Swap: CoW Protocol v2 Swap UI

[alfetopito]

Looks good, works fine.

I'm just confused by one interface