Fix for connector issue when opening as safe app #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite All Contributors have signed the CLA. |
|
|
Maybe not related to this PR, but I see that the Safe app takes data from local CowSwap app storage for affiliate flow. Is this OK? |
|
@elena-zh Since the Cowswap is loaded in Safe as an Iframe, apparently the localStorage data is also loaded from the Cowswap. I'm not really sure if this is the issue or not, but yea its not for this PR. |
anxolin
approved these changes
Jun 18, 2022
|
In principle, we could display a finer message for the Gnosis Safe App case, but I think is ok. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #580
Fixes the connector issue when opening Cowswap as an Gnosis Safe app.
To reproduce the issue
1.- Ensure Metamask is disconnected from CowSwap
2.- Connect Metamask to the Safe (for Safe link use this https://gnosis-safe.io/app/share/safe-app?appUrl=https://pr701--cowswap.review.gnosisdev.com&chainId=1)
3.- Open CowSwap Safe App and will b e working as expected
4.- Move out of CowSwapSafe app
5.- Go to CowSwap web and connect Metamask.
6.- Reload CowSwap web
7.- Open again as Safe App and will be connected to Metamask instead of the Safe
In this PR, in the step 7 you should be connected with Gnosis Safe account and not MM account, that is the fix