-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix swap.cow.fi appData bug #698
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Just one concern about additional spaces in the regexp.
Co-authored-by: Nicholas Rodrigues Lordello <[email protected]>
Co-authored-by: Leandro Boscariol <[email protected]>
Co-authored-by: Nicholas Rodrigues Lordello <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! although I would think that the problem was also that we are sending 0x0 if there's not a known pattern in the URL
I would add some metadata as the default, so we differenciate between us sending orders from "known" domains and others sending orders with all 0s
Co-authored-by: Anxo Rodriguez <[email protected]>
CLA Assistant Lite All Contributors have signed the CLA. |
Co-authored-by: Nicholas Rodrigues Lordello <[email protected]>
I just had a nice idea for using as a default. Because @alfetopito is making the meta-info dynamic, maybe we will want to use always the domain in the appCode field of the meta-information. This way, this info will be already part of the meta-info, making it more informative. We don't need to do patter matching any more to decide the appData, its always dynamic. WDYT? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the underlying issue was not solved as explained here #698 (review)
However, I think is not worth doing it, if we do what I suggest here:
#698 (comment)
In my PR, I still rely on these mappings as fallback, and also use that to set environment key |
@anxolin maybe make an issue for your concern, @alfetopito can coordinate as I'm not familiar with that code so much. merging this |
The advantage of making it all I agree that the "holy grail" would be to make it entirely dynamic and compute some app data based on the current domain. |
Summary
Fixes issue raised by @nlordell here
Regex test: