Fix iOS scrolling mobile menu overlay attempt and improve events #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite All Contributors have signed the CLA. |
|
@elena-zh could you test how the scrolling of the mobile menu overlay is for you now? |
|
|
Hey @fairlighteth , great changes! Just a tiny issue I noticed that now the app logo and the cross icon overlap the menu when scroll it: Could you please fix it? |
|
@elena-zh Thanks for reviewing! Can you re-check the last issue you had? It should be fixed now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
noScrollclass to Body. It got added then removed right away when the mobile menu overlay was open. While it should stay added. Fixed now.isLargeAndUpisTouchand use that to have the app pickonClickvsonTouchStartevent.