Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add footer margin on small and medium resolutions. #652

Merged
merged 1 commit into from
Jun 7, 2022

Conversation

fairlighteth
Copy link
Contributor

Summary

  • Add footer margin for small/medium resolutions

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2022

CLA Assistant Lite All Contributors have signed the CLA.

@fairlighteth fairlighteth requested a review from a team June 7, 2022 14:57
@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2022

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

@elena-zh
Copy link

elena-zh commented Jun 7, 2022

Hey @fairlighteth , changes LGTM!

However, I'd like to point your attention, that block info is not visible in a tablet and mobile resolutions. It is an old-old issue #102 , but it would be awesome if you could tackle it here.

@fairlighteth
Copy link
Contributor Author

@elena-zh Thanks for reviewing. I propose to address the other issue separately.

@fairlighteth fairlighteth merged commit 294a355 into improve-header-1 Jun 7, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 7, 2022
@fairlighteth fairlighteth deleted the improve-header-1-footerMargin branch July 4, 2024 15:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants