Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-position Appzi modal on mobile. #651

Merged
merged 13 commits into from
Jun 9, 2022

Conversation

fairlighteth
Copy link
Contributor

Summary

  • Reposition Appzi modal on mobile only

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2022

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2022

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

@fairlighteth fairlighteth requested a review from a team June 7, 2022 15:17
@elena-zh
Copy link
Contributor

elena-zh commented Jun 7, 2022

Hey @fairlighteth , I do not see any changes in repositioning the modal :(
image

@fairlighteth
Copy link
Contributor Author

fairlighteth commented Jun 8, 2022

@elena-zh fixed the issue of the margin on the account page here.

As for the Appzi modal position, somehow on localhost it adds the styles required. In the PR link these (global) styles aren't loaded. I currently am not sure why and would suggest to see how it does on production.

I just would want another dev review because of more logic added.

for reference I had this commented out when testing:

  if (!FEEDBACK_ENABLED) {
    return null
  }

@fairlighteth fairlighteth requested a review from a team June 8, 2022 16:56
@fairlighteth
Copy link
Contributor Author

@elena-zh For now I used a simple override that seems to work (tested on PR link). Let me know if this addresses your initial comment on this.

@elena-zh
Copy link
Contributor

elena-zh commented Jun 9, 2022

Hey @fairlighteth , appzi modal looks good to me here!

Account page margin looks better here as well, but not completely fixed. See: the button still is too big, overlaps contacts, and is not center-aligned.
image
Also, it would be nice to increase margin between the Referrals section and the overall section boarder
image

However, changes for Account page may be addressed in a separate PR, so I'm approving the current one.

@fairlighteth
Copy link
Contributor Author

@elena-zh Thank you!

@fairlighteth fairlighteth merged commit 145daad into improve-header-1 Jun 9, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 9, 2022
@alfetopito alfetopito deleted the improve-header-1-appziModal branch June 17, 2022 13:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants