-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-position Appzi modal on mobile. #651
Conversation
CLA Assistant Lite All Contributors have signed the CLA. |
|
Hey @fairlighteth , I do not see any changes in repositioning the modal :( |
@elena-zh fixed the issue of the margin on the account page here. As for the Appzi modal position, somehow on localhost it adds the styles required. In the PR link these (global) styles aren't loaded. I currently am not sure why and would suggest to see how it does on production. I just would want another dev review because of more logic added. for reference I had this commented out when testing:
|
@elena-zh For now I used a simple override that seems to work (tested on PR link). Let me know if this addresses your initial comment on this. |
Hey @fairlighteth , appzi modal looks good to me here! Account page margin looks better here as well, but not completely fixed. See: the button still is too big, overlaps contacts, and is not center-aligned. However, changes for Account page may be addressed in a separate PR, so I'm approving the current one. |
@elena-zh Thank you! |
Summary