Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for Analytics 4 and add settings event #577

Merged
merged 13 commits into from
Jun 3, 2022
Merged

Conversation

anxolin
Copy link
Contributor

@anxolin anxolin commented May 26, 2022

Summary

Universal Analytics will be deprecated, and the new Google Analytics 4 will be the official one.

This PR setups the new analytics ID. It makes use of the recent changes from Uniswap which changed the library react-ga (which only supports Universal Analytics) to react-ga4 (which uses almost the same interface and uses ga4)

More info in the deprecation
https://support.google.com/analytics/answer/11583528?hl=en

For this PR it was set up a new analytics configuration for our new organisation, so gnosis one won't be used any more.

This PR depends in the merge in #441 and will be a pre-requirement for the new Funnel that Mindy will prepare.

To Test

  1. Visit the URL in this PR
  2. Check we are getting our analytics info in our newly created analytics

@github-actions
Copy link
Contributor

github-actions bot commented May 26, 2022

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link
Contributor

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

@anxolin anxolin requested a review from a team June 2, 2022 10:14
Copy link
Contributor

@W3stside W3stside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve

Side comment: linting changes are creating a lot of noise rn, wondering where exactly it's coming from

@anxolin anxolin changed the title Prepare for Analytics 4 Prepare for Analytics 4 and add settings event Jun 3, 2022
@anxolin anxolin changed the base branch from uni-merge-1.0.6 to release/1.15.0 June 3, 2022 15:42
@anxolin anxolin merged commit b366fe6 into release/1.15.0 Jun 3, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 3, 2022
@alfetopito alfetopito deleted the analytics-ga4 branch June 6, 2022 09:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants