-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for Analytics 4 and add settings event #577
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Assistant Lite All Contributors have signed the CLA. |
|
W3stside
approved these changes
Jun 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve
Side comment: linting changes are creating a lot of noise rn, wondering where exactly it's coming from
anxolin
changed the title
Prepare for Analytics 4
Prepare for Analytics 4 and add settings event
Jun 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Universal Analytics will be deprecated, and the new Google Analytics 4 will be the official one.
This PR setups the new analytics ID. It makes use of the recent changes from Uniswap which changed the library react-ga (which only supports Universal Analytics) to react-ga4 (which uses almost the same interface and uses ga4)
More info in the deprecation
https://support.google.com/analytics/answer/11583528?hl=en
For this PR it was set up a new analytics configuration for our new organisation, so gnosis one won't be used any more.
This PR depends in the merge in #441 and will be a pre-requirement for the new Funnel that Mindy will prepare.
To Test