-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[COW-SDK] - replace SupportedChainId and change xDai > Gnosis Chain #561
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,18 +1,18 @@ | ||
import SafeServiceClient, { SafeInfoResponse, SafeMultisigTransactionResponse } from '@gnosis.pm/safe-service-client' | ||
import { registerOnWindow } from 'utils/misc' | ||
import { ChainId } from '@uniswap/sdk' | ||
import { SupportedChainId as ChainId } from 'constants/chains' | ||
|
||
const SAFE_TRANSACTION_SERVICE_URL: Partial<Record<number, string>> = { | ||
[ChainId.MAINNET]: 'https://safe-transaction.gnosis.io', | ||
[ChainId.RINKEBY]: 'https://safe-transaction.rinkeby.gnosis.io', | ||
[ChainId.XDAI]: 'https://safe-transaction.xdai.gnosis.io', | ||
[ChainId.GNOSIS_CHAIN]: 'https://safe-transaction.xdai.gnosis.io', | ||
} | ||
|
||
const SAFE_BASE_URL = 'https://gnosis-safe.io' | ||
const CHAIN_SHORT_NAME: Partial<Record<number, string>> = { | ||
[ChainId.MAINNET]: 'eth', // https://github.com/ethereum-lists/chains/blob/master/_data/chains/eip155-1.json | ||
[ChainId.RINKEBY]: 'rin', // https://github.com/ethereum-lists/chains/blob/master/_data/chains/eip155-4.json | ||
[ChainId.XDAI]: 'xdai', // https://github.com/ethereum-lists/chains/blob/master/_data/chains/eip155-100.json | ||
[ChainId.GNOSIS_CHAIN]: 'xdai', // https://github.com/ethereum-lists/chains/blob/master/_data/chains/eip155-100.json | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Isn't the short name actually gno, based on this https://github.com/ethereum-lists/chains/blob/71bbadb6878db890f2763c8a84b5ed0b94d0e353/_data/chains/eip155-100.json#L21 ? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It is, but this is only internal. |
||
} | ||
|
||
const SAFE_TRANSACTION_SERVICE_CACHE: Partial<Record<number, SafeServiceClient | null>> = {} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we maybe update the env variable names for consistency or is it fine to leave it as this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, will create an issue to address it post merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#579