Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: price lock #5332

Merged
merged 2 commits into from
Jan 24, 2025
Merged

fix: price lock #5332

merged 2 commits into from
Jan 24, 2025

Conversation

alfetopito
Copy link
Collaborator

@alfetopito alfetopito commented Jan 23, 2025 •
edited
Loading

Summary

Price locking/unlocking should work again as expected

I broke the unlocking in this PR #5304, although I could swear it was working when I tested...
Well, I was mistaken.

To Test

  1. Play around with prices and amounts while the price is locked
  • Should behave like prod
  1. Play around with prices and amounts while the price is unlocked
  • Price should be updated when amounts are changed
  • Opposite amount should be updated when price is edited

@vercel Vercel
Copy link

vercel bot commented Jan 23, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
cowfi ✅ Ready (Inspect) Visit Preview Jan 23, 2025 5:01pm
explorer-dev ✅ Ready (Inspect) Visit Preview Jan 23, 2025 5:01pm
swap-dev ✅ Ready (Inspect) Visit Preview Jan 23, 2025 5:01pm
3 Skipped Deployments
Name Status Preview Updated (UTC)
cosmos ⬜️ Ignored (Inspect) Visit Preview Jan 23, 2025 5:01pm
sdk-tools ⬜️ Ignored (Inspect) Visit Preview Jan 23, 2025 5:01pm
widget-configurator ⬜️ Ignored (Inspect) Visit Preview Jan 23, 2025 5:01pm

@alfetopito alfetopito self-assigned this Jan 23, 2025
@alfetopito alfetopito requested review from a team January 23, 2025 16:56
@alfetopito alfetopito marked this pull request as ready for review January 23, 2025 16:56
elena-zh
elena-zh approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, works now!

@alfetopito
Copy link
Collaborator Author

Merging for testing, will address the comments in a new PR

@alfetopito alfetopito merged commit 0dbc184 into feat/limit-ui-upgrade Jan 24, 2025
12 of 13 checks passed
@alfetopito alfetopito deleted the fix/price-lock branch January 24, 2025 09:57
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@elena-zh elena-zh elena-zh approved these changes

@shoom3301 shoom3301 shoom3301 approved these changes

Assignees

@alfetopito alfetopito

Labels
Limit orders upgrade
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alfetopito @shoom3301 @elena-zh