Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(limit-orders): redesign limit orders #5249

Open
wants to merge 159 commits into
base: develop
Choose a base branch
from

Conversation

shoom3301
Copy link
Collaborator

Summary

Added the changes on top of this PR:

  1. Global USD input
  2. Limit price USD input
  3. Pulled changes from develop where with fix(limit-orders): do not override user entered price #5232 fix

)

* refactor: extract utils from OrderRow

* refactor: get rid of CurrencySymbolItem

* refactor: move OrderRow component to containers

* refactor: extract custom hooks from OrderRow

* refactor: extract CurrencyAmountItem component

* refactor: get rid of renderLimitPrice

* refactor: remove orderRateInfo duplicate

* refactor: remove excessive showIcon prop from WarningTooltip

* refactor: cache warningText value

* refactor: extract OrderMarketPrice component

* chore: fix import

* refactor: extract WarningEstimatedPrice component

* refactor: get rid of renderWarningTooltip

* chore: fix types
…l/cowswap into feat/refactor-order-row-2

# Conflicts:
#	apps/cowswap-frontend/src/modules/ordersTable/containers/OrderRow/index.tsx
shoom3301 and others added 5 commits January 24, 2025 17:17
* fix(orders-table): fix limit price inverting

* chore: fix lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants