Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove COW from locked GNO from subsidy calculation #512

Merged
merged 2 commits into from
May 4, 2022
Merged

Remove COW from locked GNO from subsidy calculation #512

merged 2 commits into from
May 4, 2022

Conversation

nenadV91
Copy link
Contributor

@nenadV91 nenadV91 commented May 4, 2022 •
edited
Loading

Summary

Fixes #497

Removes COW from locked GNO from vested calculation and also from header balance button

To test

  • we want to make sure that the COW vested from locked GNO is not included in the subsidy percentage and balance button

@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2022

CLA Assistant Lite All Contributors have signed the CLA.

@nenadV91 nenadV91 requested review from a team May 4, 2022 10:38
@nenadV91 nenadV91 changed the title 497/remove COW from locked GNO from subsidy Remove COW from locked GNO from subsidy calculation May 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2022

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

anxolin
anxolin approved these changes May 4, 2022
View reviewed changes
Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice you parametriced. It would be enough with commenting out.

When we start using the locked gno for subsidy, I would revert this PR, because I don't think we will need the parametrisation in the future.

@elena-zh
Copy link

elena-zh commented May 4, 2022

@nenadV91 , then, I think, we should remove this amount from the (v)COW button's balance
image

WDYT?

@nenadV91
Copy link
Contributor Author

nenadV91 commented May 4, 2022

@anxolin I've changed it to comments to remove locked balance from both header button and subsidy as @elena-zh suggested.

elena-zh
elena-zh approved these changes May 4, 2022
View reviewed changes
Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now!

@elena-zh elena-zh mentioned this pull request May 4, 2022
Closed
@nenadV91 nenadV91 merged commit b835015 into release/1.14 May 4, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 4, 2022
@elena-zh
Copy link

elena-zh commented May 4, 2022

Btw, I have reopened #409 issue in order not to forget to add it when BE functionality is ready.

@alfetopito alfetopito deleted the 497/remove-locked-gno-subsidy branch May 4, 2022 12:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@elena-zh elena-zh elena-zh approved these changes

@anxolin anxolin anxolin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nenadV91 @elena-zh @anxolin