Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: misc hooks improvements #5079

Merged
merged 5 commits into from
Nov 14, 2024
Merged

feat: misc hooks improvements #5079

merged 5 commits into from
Nov 14, 2024

Conversation

fairlighteth
Copy link
Contributor

@fairlighteth fairlighteth commented Nov 11, 2024

Summary

  • Misc layout improvements
  • Change 'Add' to 'Open' for the button for each Hook in the list
  • Hide tabs when in hook detail (selected hook)

Copy link

vercel bot commented Nov 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
cosmos ✅ Ready (Inspect) Visit Preview Nov 14, 2024 8:15am
cowfi ✅ Ready (Inspect) Visit Preview Nov 14, 2024 8:15am
explorer-dev ✅ Ready (Inspect) Visit Preview Nov 14, 2024 8:15am
swap-dev ✅ Ready (Inspect) Visit Preview Nov 14, 2024 8:15am
widget-configurator ✅ Ready (Inspect) Visit Preview Nov 14, 2024 8:15am

@fairlighteth fairlighteth marked this pull request as ready for review November 11, 2024 10:22
Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alll changes make sense

Should we also add in a follow up PR a banner here?
image

Could be similar to what we have:
image

But should point here: https://docs.cow.fi/cow-protocol/tutorials/hook-dapp

Copy link
Contributor

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants