-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[414] remove NetworkSelector on sc wallet session #507
Conversation
CLA Assistant Lite: I have read the CLA Document and I hereby sign the CLA You can retrigger the CLA Action by commenting recheckcla in this Pull Request |
src/custom/components/Header/NetworkSelector/NetworkSelectorMod.tsx
Outdated
Show resolved
Hide resolved
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the notes above
@elena-zh can you check this is the case outside of this PR?
…On Tue, 3 May 2022, 15:43 Elena, ***@***.***> wrote:
Network selector presents when connect to Gnosis Safe mobile wallet (all
networks)
[image: image]
<https://user-images.githubusercontent.com/70885163/166475861-51ab04f4-938b-4ec0-a8dd-5c8bddacf5ca.png>
—
Reply to this email directly, view it on GitHub
<#507 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFCY4CYCTP54OZWSU4WGHXLVIE3STANCNFSM5U7B5MOA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
DEV environment: the issue is reproducible there Prod environment: the network selector is disabled for this case. Let me know please if I need to retest it somewhere else. |
Hey @W3stside , now the network switcher is displayed to a not connected user. And the network switcher is removed when connected to Gnosis Safe in Mainnet, and to a mobile Gnosis Safe wallet in Mainnet. But still, the selector is displayed when connected to Argent wallet |
@elena-zh yeah didnt have the right changes in there, could u recheck after the build is remade? |
Hey @W3stside , works nicely now with Gnosis Safe wallet for all networks. However, I still see the network selector when connected to Argent or Pillar wallets. Could we hide it? Thanks |
@elena-zh pillar i wont do rn since i have no experience with it but argent should be done now |
@W3stside , seems that there is an issue with the latest build |
there wasn't, what do you see wrong? |
I have not seen changes in the PR. |
Closes #414
Test