Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable anniversary release #499

Merged
merged 3 commits into from
May 2, 2022
Merged

Conversation

alfetopito
Copy link
Collaborator

@alfetopito alfetopito commented May 2, 2022

Summary

Disable anniversary release

To Test

  1. Open the page
  • Should not contain the anniversary banner
  1. Place an order
  • Should have the regular cow sound

@alfetopito alfetopito changed the base branch from develop to hotfix/1.13.4 May 2, 2022 15:33
@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2022

CLA Assistant Lite All Contributors have signed the CLA.

@alfetopito alfetopito self-assigned this May 2, 2022
@alfetopito alfetopito requested review from a team May 2, 2022 15:35
@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2022

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

Copy link
Contributor

@W3stside W3stside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldnt we just flag disable it? Be8st year we'll do this again likely

@alfetopito
Copy link
Collaborator Author

Couldnt we just flag disable it? Be8st year we'll do this again likely

Who knows what the UI will look like in 1 year. I wouldn't count it being very compatible then

@alfetopito alfetopito force-pushed the disable-anniversary-release branch from c4b430f to b8c47ca Compare May 2, 2022 15:49
@alfetopito
Copy link
Collaborator Author

Merging to start preparing the version.

Likely not going out today given the time and devops availability.

Still, would like to get it ready for as soon as we can

1 similar comment
@alfetopito
Copy link
Collaborator Author

Merging to start preparing the version.

Likely not going out today given the time and devops availability.

Still, would like to get it ready for as soon as we can

@alfetopito alfetopito merged commit 54b92b7 into hotfix/1.13.4 May 2, 2022
@alfetopito alfetopito deleted the disable-anniversary-release branch May 2, 2022 16:26
@github-actions github-actions bot locked and limited conversation to collaborators May 2, 2022
@anxolin anxolin restored the disable-anniversary-release branch May 2, 2022 16:43
@alfetopito alfetopito deleted the disable-anniversary-release branch July 18, 2022 16:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants