Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sound #478

Merged
merged 1 commit into from
Apr 28, 2022
Merged

Add sound #478

merged 1 commit into from
Apr 28, 2022

Conversation

anxolin
Copy link
Contributor

@anxolin anxolin commented Apr 28, 2022

Summary

Add mastercow sound and celebration sound for anniversaly

Additionally, allows to add some optional onClick handler for the external link

Test

  • Trade and wait for execution. Hear the new sound
  • Click on sharing button. Hear the celbration sound

@github-actions
Copy link
Contributor

CLA Assistant Lite All Contributors have signed the CLA.

@alfetopito alfetopito merged commit eb29f1e into hotfix/1.13.2 Apr 28, 2022
@alfetopito alfetopito deleted the add-sounds branch April 28, 2022 11:29
@github-actions github-actions bot locked and limited conversation to collaborators Apr 28, 2022
@alfetopito
Copy link
Collaborator

Already merged to prepare the release.
Post merge review, or review the hotfix PR directly #477

@elena-zh
Copy link

elena-zh commented Apr 28, 2022

Can't test due to there is still no a preview link, but I can assume that the success sound is played after a successful convert vCOW to COW transaction. Noted in #474 (comment)
Are we OK with this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants