Add anniversary banner. #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Noticed, that it this PR footer elements are displayed above the banner in a mobile view |
* Handle close and read/save localStorage. * Handle close and read/save localStorage. * Refactor getting localstorage value * Refactor using useMemo * Remove string props * store as constant * use and expose ENUM for bannerType * Add component inside Suspense * refactor getshowbannerstate * refactor getshowbannerstate * rename isVisible * Making integ tests pass with the new anniversary banner Revert this when the banner is disabled * Reverted change that caused some content to be hidden * Update src/custom/pages/App/index.tsx Co-authored-by: Leandro Boscariol <[email protected]> Co-authored-by: fairlighteth <[email protected]>
|
CLA Assistant Lite All Contributors have signed the CLA. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Same thing as #468, except that it's against
mainrather thandevelop.