Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[450 - Fix locales breakybreaky] mod locales constant and set paths correctly #464

Merged
merged 1 commit into from
Apr 27, 2022
Merged

[450 - Fix locales breakybreaky] mod locales constant and set paths correctly #464

merged 1 commit into from
Apr 27, 2022

Conversation

W3stside
Copy link
Contributor

Summary

Closes #450

Mods the new uni constants file locales.ts

To Test

  1. boot up a non english US set machine
  2. boot cowswap
  3. shouldnt see squiglybois anywhere

@github-actions
Copy link
Contributor

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link
Contributor

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

@W3stside W3stside changed the title mod locales constant and set paths correctly [450 - Fix locales breakybreaky] mod locales constant and set paths correctly Apr 27, 2022
elena-zh
elena-zh approved these changes Apr 27, 2022
View reviewed changes
Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@W3stside , changes LGTM (besides a newly fount issue #465 that was not exactly introduced in this PR, but reproducible here)

@W3stside W3stside merged commit 4c2e2c6 into develop Apr 27, 2022
@W3stside W3stside deleted the 450/locale-issue branch April 27, 2022 16:17
@github-actions github-actions bot locked and limited conversation to collaborators Apr 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@elena-zh elena-zh elena-zh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@W3stside @elena-zh