-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modded and fixed issue when token image loading failed #443
Conversation
CLA Assistant Lite All Contributors have signed the CLA. |
setColor(color) | ||
} | ||
}) | ||
.catch(console.warn) // mod: error handling |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only effective change in this whole mod
|
Hey @alfetopito , is this OK that 'CowProtocol' token list's image cannot be loaded in this PR? |
Does that happen on production? |
@alfetopito , no, the list icon looks good in Production |
Regardless, those images are unrelated to the changes here. I'll merge the PR as is |
@alfetopito , I switched off my add blocker and it started to show icons. |
Summary
Part of #438
Fixed one issue that was causing the dev build to blow up with an unhandled exception when the token list image failed to load.
That wasn't visible on prod as it was just swallowed and logged as an error in the console.
Now it's handled and logged as a warning.
To Test
Note
I did not manage to fix the issue on #438
Need some CSS help on that front