Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modded and fixed issue when token image loading failed #443

Merged
merged 1 commit into from
Apr 22, 2022

Conversation

alfetopito
Copy link
Collaborator

Summary

Part of #438

Fixed one issue that was causing the dev build to blow up with an unhandled exception when the token list image failed to load.
That wasn't visible on prod as it was just swallowed and logged as an error in the console.

Now it's handled and logged as a warning.

To Test

  1. On mainnet, go to manage token lists
  • There should be a warning about an image not being found like this
    Screen Shot 2022-04-22 at 10 49 31
  • If you running this locally, this page should no longer crash

Note

I did not manage to fix the issue on #438
Need some CSS help on that front

@github-actions
Copy link
Contributor

CLA Assistant Lite All Contributors have signed the CLA.

@alfetopito alfetopito requested review from a team April 22, 2022 10:31
setColor(color)
}
})
.catch(console.warn) // mod: error handling
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only effective change in this whole mod

@github-actions
Copy link
Contributor

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

@elena-zh
Copy link

Hey @alfetopito , is this OK that 'CowProtocol' token list's image cannot be loaded in this PR?
GC:
GC

Mainnet:
mainn

@alfetopito
Copy link
Collaborator Author

Hey @alfetopito , is this OK that 'CowProtocol' token list's image cannot be loaded in this PR? GC: GC

Mainnet: mainn

Does that happen on production?
I suspect it might be some setting in our dev environment, as it's nothing new AFAICT

@elena-zh
Copy link

@alfetopito , no, the list icon looks good in Production

@alfetopito
Copy link
Collaborator Author

Not sure what could be happening but looks like an issue in your side Elena.
Maybe you have a browser setting or an add-on that's blocking those requests?

I've just tested with the link from this PR

Screen Shot 2022-04-22 at 15 58 25
Screen Shot 2022-04-22 at 15 57 43

@alfetopito
Copy link
Collaborator Author

Regardless, those images are unrelated to the changes here. I'll merge the PR as is

@alfetopito alfetopito merged commit 31ad497 into develop Apr 22, 2022
@alfetopito alfetopito deleted the 438/fix-manage-lists branch April 22, 2022 15:01
@github-actions github-actions bot locked and limited conversation to collaborators Apr 22, 2022
@elena-zh
Copy link

@alfetopito , I switched off my add blocker and it started to show icons.
Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants