-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
410/empty from field #440
410/empty from field #440
Conversation
CLA Assistant Lite All Contributors have signed the CLA. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice finding!
I love the PR, easy to review, easy to test, fixes the issue
Hey @alfetopito , great job! However, 'From' field's height is too small now in comparison with 'To' field when 'Select token is displayed in it. Compare with the current Prod version: Could you please fix it? Thanks! |
Hmm, probrably the same issue Elena, let me try to fix that too |
@elena-zh should be fixed now 🤞 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alfetopito , LGTM now!
Summary
Fixes #410
Fixed one condition causing
null
input tokens from URL to not show the token selector dropdownTo Test
buy COW
sell
token input should have a token selector dropdown