Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

410/empty from field #440

Merged
merged 2 commits into from
Apr 22, 2022
Merged

410/empty from field #440

merged 2 commits into from
Apr 22, 2022

Conversation

alfetopito
Copy link
Collaborator

Summary

Fixes #410

Fixed one condition causing null input tokens from URL to not show the token selector dropdown

To Test

  1. Go to profile page
  2. Click on buy COW
  • On the swap page, the sell token input should have a token selector dropdown

@alfetopito alfetopito self-assigned this Apr 21, 2022
@alfetopito alfetopito requested review from a team April 21, 2022 17:20
@github-actions
Copy link
Contributor

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link
Contributor

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice finding!

I love the PR, easy to review, easy to test, fixes the issue

@elena-zh
Copy link

Hey @alfetopito , great job!

However, 'From' field's height is too small now in comparison with 'To' field when 'Select token is displayed in it.
Look:
fields with diff width

Compare with the current Prod version:
prod

Could you please fix it?

Thanks!

@alfetopito
Copy link
Collaborator Author

Hmm, probrably the same issue Elena, let me try to fix that too

@alfetopito
Copy link
Collaborator Author

@elena-zh should be fixed now 🤞

Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alfetopito , LGTM now!

@alfetopito alfetopito merged commit f29e974 into develop Apr 22, 2022
@alfetopito alfetopito deleted the 410/empty-from-field branch April 22, 2022 10:22
@github-actions github-actions bot locked and limited conversation to collaborators Apr 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Uni merge] Empty From field is displayed when press on the Buy COW button
4 participants