-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Profile: Conditional 'Add Token' vs 'Copy contract address': Waterfall PR[6] #383
Conversation
CLA Assistant Lite: I have read the CLA Document and I hereby sign the CLA You can retrigger the CLA Action by commenting recheckcla in this Pull Request |
|
Hey @fairlighteth , great changes! All the rest changes LGTM! |
@elena-zh Was thinking about it indeed... you think it makes sense? In that case we add the 'Copy token contract' but not the 'Add To Metamask' ? Because the token is non transferable anyway? I think at the very least we add the 'copy token contract'. |
@fairlighteth , agree with you that there is no need to add 'Add to MM' button to the vCOW card. It is enough to have 'Copy' there with no regard to a type of connected wallet. |
* Mobile responsive. * Mobile responsive fix + add copy contract vCOW
Build complete after merging in waterfall PR [7]. Tested and works. Continuing merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good
Summary
WalletConnect with a Safe
Screen.Recording.2022-04-06.at.11.10.13.mov
MetaMask
Screen.Recording.2022-04-06.at.11.10.38.mov