-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Claim vested COW for locked GNO #364
Conversation
CLA Assistant Lite: I have read the CLA Document and I hereby sign the CLA 1 out of 2 committers have signed the CLA. |
@jfschwarz note we need to recreate this PR because we are migrating all repositories. I'll add to the slack chat some details |
|
Hi, @jfschwarz , as mentioned in the chat:
|
Hey @jfschwarz , I have verified the latest changes related to the gnosis/cowswap#2599 (comment) issue, and they LGTM! The only thing is left, is to complete test scenario and run a successful claim transaction. For this, it would great is you can deploy a test contract in Rinkeby with test accounts with locked GNO. |
516a2b7
to
1850085
Compare
I have read the CLA Document and I hereby sign the CLA |
Hey @jfschwarz , @anxolin |
Just wanted to point out that the dashboard won't display the amount of vested COW due to this. That computation was performed using an aggregation of the total amounts of "locked" GNO on each network and the 50M was distributed as each accounts proportion of the total. I could probably put together a query that shows this if anyone would like. |
We have added 'View Contract' and 'Copy contract' buttons to the cards. So, besides the Moo sound (if we decide to use it) it would be nice to add these buttons to the 'Claim COW form locked GNO' card as well |
Closed in favor of #405 |
Summary
This PR adds a section to the profile page for letting users claim vested COW tokens they received for locking GNO.
To Test
Open the page Profile
Claim the vested COW
Background
To prevent a negative impact on page load performance, the merkle proof data for claiming the vested tokens is chunked and will be fetched lazily only when navigating to the profile page. The data can be found in this external repo: https://github.com/gnosis/locked-gno-cow-merkle-distro