Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SENTRY] Context and error description cleanup #361

Merged
merged 4 commits into from
Apr 7, 2022

Conversation

W3stside
Copy link
Contributor

@W3stside W3stside commented Apr 4, 2022

Part of ongoing Sentry fixes

Adds Sentry "context" updater and removes unnecessary user params from error messages

e.g on sentry:
Sentry user context

@W3stside W3stside requested a review from a team April 4, 2022 10:33
@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2022

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2022

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

@W3stside W3stside changed the base branch from develop to master April 5, 2022 14:36
@W3stside W3stside changed the base branch from master to release/1.13 April 5, 2022 14:36
@anxolin anxolin requested review from anxolin and nenadV91 April 6, 2022 14:17
Copy link
Contributor

@nenadV91 nenadV91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from that one comment LGTM 👍

Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Soft approve

src/custom/state/sentry/updater/index.ts Outdated Show resolved Hide resolved
src/custom/state/sentry/updater/index.ts Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2022

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

useEffect(() => {
if (windowVisible) {
Sentry.setContext('user', {
userAddress: account || 'DISCONNECTED',
Copy link
Contributor

@anxolin anxolin Apr 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

David, pls validate with legal about this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that will take a while

Copy link
Contributor

@anxolin anxolin Apr 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i see u removed. pls makes sure is ok and re-enable if possible. in the mean time, ill merge in the current state (without)

@anxolin anxolin merged commit 2028ef3 into release/1.13 Apr 7, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 7, 2022
@fairlighteth fairlighteth deleted the sentry-context-updater branch July 4, 2024 15:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants