-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: simplify theme config #3363
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
anxolin
force-pushed
the
simplify-some-conf
branch
from
November 8, 2023 17:03
94fcabb
to
04ff70a
Compare
anxolin
force-pushed
the
simplify-theme
branch
from
November 8, 2023 18:27
a48a71c
to
0b33fdb
Compare
anxolin
force-pushed
the
simplify-theme
branch
from
November 8, 2023 18:42
e627037
to
2041370
Compare
shoom3301
approved these changes
Nov 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is really simple and laconic!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I feel that in order to control the theme, is easier if we just have a single
theme
parameter.In this PR I propose to:
palette
parametertheme
to allow more controlBasically you would use it like this:
Test
it should work as before, its just, we don't have 2 properties. Just one theme
You can uncomment this to see the new colors: https://github.com/cowprotocol/cowswap/blob/simplify-theme/apps/widget-configurator/src/app/configurator/hooks/useWidgetParamsAndSettings.ts#L45