Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(permit): add publish package action #3271

Merged
merged 2 commits into from
Oct 27, 2023

Conversation

alfetopito
Copy link
Collaborator

Summary

Adding a manual publish package action.

Right now, only permit-utils lib is publishable.

To Test

Was not able to test it manually.
Also not testable in the PR as it'll need to be merged to develop first.

@vercel
Copy link

vercel bot commented Oct 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
swap-dev 🔄 Building (Inspect) Visit Preview Oct 27, 2023 5:04pm

🌃 Cosmos ↗︎

Comment on lines +11 to +12
- permit-utils
# Add more publishable libs here
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything that can be published should be manually added here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's looks easy enough process!

name: Publish

on:
workflow_dispatch: # Manually trigger it via UI/CLI/API
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can only be manually triggered

@alfetopito alfetopito marked this pull request as ready for review October 25, 2023 15:19
@alfetopito alfetopito self-assigned this Oct 25, 2023
@alfetopito alfetopito requested a review from a team October 25, 2023 15:19
Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! lets merge and see if it works :)

Comment on lines +11 to +12
- permit-utils
# Add more publishable libs here
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's looks easy enough process!

Copy link
Collaborator

@shoom3301 shoom3301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@alfetopito alfetopito force-pushed the permit/export-package branch 2 times, most recently from aca2086 to d1b55a2 Compare October 27, 2023 15:55
@alfetopito alfetopito changed the base branch from permit/export-package to develop October 27, 2023 17:03
@alfetopito alfetopito force-pushed the permit/publish-package-action branch from 7d59929 to 92f59f8 Compare October 27, 2023 17:04
@alfetopito alfetopito merged commit 46e7eaa into develop Oct 27, 2023
@alfetopito alfetopito deleted the permit/publish-package-action branch October 27, 2023 17:08
@github-actions github-actions bot locked and limited conversation to collaborators Oct 27, 2023
@alfetopito
Copy link
Collaborator Author

FYI, it did not work as it is.
Needed a few attempts.

Here's the final working version https://github.com/cowprotocol/cowswap/blob/b58425eb538342a716d747c2940095776bb677d9/.github/workflows/publish.yml

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants