-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add widget-lib
and publish to NPM
#2704
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
anxolin
changed the title
chore: add widget lib
chore: Add Jun 21, 2023
widget-lib
and publish to NPM
shoom3301
approved these changes
Jun 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing example of addding a new lib!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the widget library to the monorepo (credits to @shoom3301 for implementing the main widget in https://shoom3301.github.io/cow-widget/)
This PR creates a publishable lib (meaning we can push it to NPM). We will also be able to use it in another monorepo project, which will make development easier.
The library has its own tests (i created tests just for the param to URL mapping (we could add more coverage if desired):
Last but not least, it adds a way to publish this into production, for that read the lib README for instructions.
For that is uses a custom script that will: copy the README, write the version in the package.json, and publish into NPM
To Test
Just run:
nx test widget-lib
To build:
nx build widget-lib
, you will see the artifacts indist/widget-lib