Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix 🔥 - 1.40.1 #2687

Merged
merged 4 commits into from
Jun 19, 2023
Merged

Hotfix 🔥 - 1.40.1 #2687

merged 4 commits into from
Jun 19, 2023

Conversation

nenadV91
Copy link
Contributor

@nenadV91 nenadV91 commented Jun 16, 2023

Summary

Changelog

ac4eb14 Revert "chore: version bump"
c65c53d fix: account page issue
8d21bd3 chore: version bump
c369dd2 fix: unsupported chain app crash (#2676)

@vercel
Copy link

vercel bot commented Jun 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
swap-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback

🌃 Cosmos ↗︎

Copy link
Contributor

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nenadV91 , I have found one more crash: when on Swap page, switch to an unsupported netowkr, then open Account-Overview page
image

@elena-zh
Copy link
Contributor

I also noticed that when we are on an unsupported network, it is impossible to open some content pages using header buttons.
To reproduce:

  1. Open FAQ section when connected to a wallet
  2. Switch to an unsupported network
  3. Then using header buttons try navigating to About page
  4. Then try navigating to CoW Runner game/Account page: I see announcement errors in the console, but I'm not navigated to the correct page

image

@nenadV91
Copy link
Contributor Author

@elena-zh
Added fix for account page

I suggest we fix that last issue in the future and deploy these already fixed on Monday.
IMO that last issue will take some more debugging time and is not as important as already fixed ones.

Copy link
Contributor

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nenadV91 , I have created #2689 issue for the last case.
The fix with the crash LGTM.
As a nitpick, I should mention that it would be nice to add 0 to the card
image

however, not critical :)

package.json Outdated Show resolved Hide resolved
@nenadV91 nenadV91 merged commit eadf970 into main Jun 19, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 19, 2023
@alfetopito alfetopito deleted the hotfix/1.40.1 branch July 3, 2023 08:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants