[3] feat(twap): add generic trade form validation to TWAP #2592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into feat/2417-2 # Conflicts: # src/modules/limitOrders/containers/TradeButtons/index.tsx # src/modules/tradeFormValidation/index.ts
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…to feat/2417-1 # Conflicts: # src/modules/tradeFormValidation/pure/TradeFormButtons/index.tsx
…into feat/2417-2 # Conflicts: # src/modules/limitOrders/containers/TradeButtons/index.tsx
shoom3301
changed the title
shoom3301
changed the title
… feat/2417 # Conflicts: # src/modules/swap/containers/SwapWidget/index.tsx
…to feat/2417-1 # Conflicts: # src/legacy/hooks/useWrapCallback.ts # src/modules/swap/hooks/useSwapButtonContext.ts
…into feat/2417-2
alfetopito
approved these changes
Jun 2, 2023
| } | ||
| const tradeFormButtonContext = useTradeFormButtonContext('Limit order', { doTrade: handleTrade, confirmTrade }) | ||
|
|
||
| if (!tradeFormButtonContext) return null |
There was a problem hiding this comment.
You are still refactoring trade stuff, I say testing is needed!
There was a problem hiding this comment.
Yeah, sorry for that :(
There are not so much changes in the existed code, anyway, there are
src/modules/tradeFormValidation/hooks/useTradeFormButtonContext.ts
Outdated
Show resolved
Hide resolved
nenadV91
approved these changes
Jun 2, 2023
… feat/2417 # Conflicts: # src/modules/limitOrders/containers/LimitOrdersWidget/index.tsx
…into feat/2417-2 # Conflicts: # src/modules/advancedOrders/containers/AdvancedOrdersWidget/index.tsx # src/modules/limitOrders/containers/TradeButtons/index.tsx # src/modules/twap/containers/TwapFormWidget/index.tsx
… feat/2417-2 # Conflicts: # src/modules/limitOrders/containers/TradeButtons/index.tsx # src/modules/tradeFormValidation/index.ts
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2417
In this PR I've added generic form validation to TWAP widget.
See:
To Test