refactor: extract TradeConfirmation component from LimitOrdersConfirmModal #2564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fix/2429-1 # Conflicts: # src/common/pure/CurrencyAmountPreview/index.tsx # src/modules/limitOrders/pure/LimitOrdersConfirm/index.tsx # src/modules/limitOrders/pure/LimitOrdersConfirm/styled.tsx
… fix/2429-1 # Conflicts: # src/common/hooks/useRateInfoParams.ts # src/common/pure/CurrencyAmountPreview/index.tsx # src/common/pure/RateInfo/index.tsx # src/modules/limitOrders/containers/LimitOrdersConfirmModal/index.tsx # src/modules/limitOrders/pure/LimitOrdersConfirm/index.cosmos.tsx # src/modules/limitOrders/pure/LimitOrdersConfirm/index.tsx # src/modules/limitOrders/utils/buildPriceFromCurrencyAmounts.ts
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shoom3301
changed the title
anxolin
reviewed
May 29, 2023
|
|
||
| import { CurrencyLogo } from 'common/pure/CurrencyLogo' | ||
| import { TokenSymbol } from 'common/pure/TokenSymbol' | ||
|
|
||
| import * as styledEl from './styled' | ||
|
|
||
| export interface CurrencySelectButtonProps { | ||
| currency?: Currency | ||
| currency?: Nullish<Currency> |
There was a problem hiding this comment.
do you still need the question-mark in the prop?
There was a problem hiding this comment.
Yes. Optional !== undefined
There was a problem hiding this comment.
fine with me, different is subtle, the point is if we want to make it optional.
Currency is even in the name of the component, and the 2 uses provide the prop
There was a problem hiding this comment.
Aaaah, got your point. Will refactor it in the next PR.
Thank you!
anxolin
approved these changes
May 29, 2023
|
In this PR (or maybe some earlier) it is impossible to create a limit order with a native token in the To field |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2429
Refactored
LimitOrdersConfirmModalin order to create a genericTradeConfirmationcomponent that can be used in any trade widget.Unfortunately, in the changes we can't see that the component is just refactored version of
LimitOrdersConfirmModal. But, in the first commit you can see that it just was moved usinggit mv.TradeConfirmationlooks like this:Essentially, it's just a representation of sell + buy amounts with an arbitrary content at the bottom.
Changes