Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix message for revoke #2536

Merged
merged 2 commits into from
May 24, 2023
Merged

Fix message for revoke #2536

merged 2 commits into from
May 24, 2023

Conversation

anxolin
Copy link
Contributor

@anxolin anxolin commented May 24, 2023 •
edited
Loading

Summary

Fixes #2534

Screenshot at May 24 14-52-51 Screenshot at May 24 14-53-17

To Test

  1. Go to CoW Swap on Goerli,
  2. Use USDT https://goerli.etherscan.io/address/0x7b77F953e703E80CD97F6911385c0b1ceabC96Bc
  3. Approve or trade to have some left over approvals (for example 5 USDT)
  4. Open Swap orders page
  5. Enter an amount higher than the approval amount (for example 10 USDT)
  6. Press on the Approve button
  7. Sign the reset approval TX in the wallet and wait till the TX is executed

@vercel
Copy link

vercel bot commented May 24, 2023 •
edited by github-actions bot
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
swap-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback

🌃 Cosmos ↗︎

@anxolin anxolin requested review from tukantje and a team May 24, 2023 14:31
@anxolin anxolin changed the base branch from develop to release/1.38.0 May 24, 2023 14:31
elena-zh
elena-zh approved these changes May 24, 2023
View reviewed changes
Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@anxolin anxolin added the RELEASE Included in the release that is being closed label May 24, 2023
tukantje
tukantje approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@tukantje tukantje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tukantje tukantje merged commit 9047065 into release/1.38.0 May 24, 2023
@tukantje tukantje deleted the fix-message-for-revoke branch May 24, 2023 16:21
@github-actions github-actions bot locked and limited conversation to collaborators May 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@elena-zh elena-zh elena-zh approved these changes

@tukantje tukantje tukantje approved these changes

@alfetopito alfetopito alfetopito approved these changes

Assignees
No one assigned
Labels
RELEASE Included in the release that is being closed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[1.38] Show an appropriate pop-up when revoke approval
4 participants
@anxolin @alfetopito @tukantje @elena-zh