feat(twap): twap order creation services #2504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shoom3301
force-pushed
the
feature/create-twap
branch
from
cc13f47 to
1a230be
Compare
shoom3301
force-pushed
the
feature/create-twap
branch
from
1a230be to
efdde8d
Compare
shoom3301
force-pushed
the
feature/create-twap
branch
from
efdde8d to
631e928
Compare
… feature/create-twap
shoom3301
commented
May 23, 2023
|
|
||
| if (!context) return null | ||
|
|
||
| return settleTwapOrder(order, context) |
alfetopito
requested changes
May 23, 2023
|
|
||
| const createOrderTx = { | ||
| to: COMPOSABLE_COW_ADDRESS[chainId], | ||
| data: composableCowContract.interface.encodeFunctionData('create', [creationParams, true]), |
There was a problem hiding this comment.
Suggestion for a different way of creating the tx data, which uses the types and parameters more in a TS fashion https://github.com/cowprotocol/cowswap/blob/ed50eb839629d7df29a404a5d4663b56330d1900/src/modules/operations/bundle/buildPresignTx.ts#L12-L11
There was a problem hiding this comment.
Yes, I'm aware of it. I don't have a strong opinion on it,but there are some differences:
encodeFunctionDatareturnsstringpopulateTransactionreturnsPromise<string>encodeFunctionDatahas type overloads, so, the interface consistency is safe
There was a problem hiding this comment.
Cool, didn't know
I don't mind also to use this version.
Then, do you think we should update the method I linked?
There was a problem hiding this comment.
Just to make it synchronous - yes, it make sense
shoom3301
force-pushed
the
feature/create-twap
branch
from
5b4819b to
51f005c
Compare
alfetopito
approved these changes
May 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The process follows common pattern: collect context -> execute logic.
Usage example.