-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2440/uni merge: remove 'in the dropdown menu' from the Wrong Network message #352
Comments
Actually, not fixed in #406 : notes are here #406 (comment) (p.1) |
I'm not sure about this. In Uniswap they do it like that, and looks good to me. Now you can be in the wrong network in the wallet, but then select a valid network in the selector. |
@elena-zh, For me this this issue is mostly an issue with not working when you click in the dropdown, right? |
@W3stside fine with me. I just checked and now it works exactly like Uniswap, so it lets you be in the wrong network and then you can select any other network, and the app changes. I think we can leave it like this |
Related to #2536
AR: Message says: 'Please connect to a supported network in the dropdown menu or in your wallet.'
But when select a network in the dropdown, nothing is changed: no request to change a network is sent to the connected wallet.
ER: it would be nice to remove 'in the dropdown menu' from the Wrong Network message
OR change its text to the currently used:
The text was updated successfully, but these errors were encountered: