Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2440/uni merge: remove 'in the dropdown menu' from the Wrong Network message #352

Closed
anxolin opened this issue Apr 2, 2022 · 6 comments · Fixed by #406 or #459
Closed

2440/uni merge: remove 'in the dropdown menu' from the Wrong Network message #352

anxolin opened this issue Apr 2, 2022 · 6 comments · Fixed by #406 or #459
Assignees
Labels
app:CowSwap CowSwap app Bug Something isn't working Low Severity indicator for defects. It won't cause any major break-down of the system

Comments

@anxolin
Copy link
Contributor

anxolin commented Apr 2, 2022

Related to #2536

  1. Open the app,
  2. Connect to an unsupported network
  3. Press on the 'Wrong Network' button

AR: Message says: 'Please connect to a supported network in the dropdown menu or in your wallet.'
But when select a network in the dropdown, nothing is changed: no request to change a network is sent to the connected wallet.
remove.jpg

ER: it would be nice to remove 'in the dropdown menu' from the Wrong Network message
OR change its text to the currently used:
image.png

Original issue gnosis/cowswap#2645 by @elena-zh

@anxolin anxolin added Low Severity indicator for defects. It won't cause any major break-down of the system app:CowSwap CowSwap app Bug Something isn't working labels Apr 2, 2022
This was referenced Apr 4, 2022
@elena-zh
Copy link

Actually, not fixed in #406 : notes are here #406 (comment) (p.1)

@elena-zh
Copy link

Btw, I think it would be great to hide a network selector when an unsupported network is selected in the connected wallet (as we currently do in the Production)
image

This was referenced Apr 25, 2022
@anxolin
Copy link
Contributor Author

anxolin commented Apr 26, 2022

Btw, I think it would be great to hide a network selector when an unsupported network is selected in the connected wallet (as we currently do in the Production)

I'm not sure about this. In Uniswap they do it like that, and looks good to me. Now you can be in the wrong network in the wallet, but then select a valid network in the selector.

@anxolin
Copy link
Contributor Author

anxolin commented Apr 26, 2022

@elena-zh, For me this this issue is mostly an issue with not working when you click in the dropdown, right?
We should be able to change networks using that, even if the connected wallet is in the wrong network.

@W3stside
Copy link
Contributor

@elena-zh, For me this this issue is mostly an issue with not working when you click in the dropdown, right? We should be able to change networks using that, even if the connected wallet is in the wrong network.

@anxolin
image

@anxolin
Copy link
Contributor Author

anxolin commented Apr 26, 2022

@W3stside fine with me. I just checked and now it works exactly like Uniswap, so it lets you be in the wrong network and then you can select any other network, and the app changes. I think we can leave it like this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:CowSwap CowSwap app Bug Something isn't working Low Severity indicator for defects. It won't cause any major break-down of the system
Projects
None yet
3 participants