Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2440/uni merge: No info block, incorrect 'View details' link navigation when run transactions with Safe wallet #342

Closed
anxolin opened this issue Apr 2, 2022 · 0 comments · Fixed by #444
Closed

2440/uni merge: No info block, incorrect 'View details' link navigation when run transactions with Safe wallet #342

anxolin opened this issue Apr 2, 2022 · 0 comments · Fixed by #444
Assignees
@alfetopito
Labels
app:CowSwap CowSwap app Bug Something isn't working Medium Severity indicator. It causes some undesirable behavior, but the system is still functional

Comments

@anxolin
Copy link
Contributor

anxolin commented Apr 2, 2022

Related to #2536

Connect to the Gnosis safe wallet

  1. Run approve/wrap/unwrap transaction
  2. Place a sell/but order

AR:

  1. transactions:
  1. sell/buy orders:
  • There is no info block about the signing by owners process.
  • 'View details' link navigates to an order details page when it is in 'Signing' state (should navigate to the Safe transactions)

ER: Safe info blocks should present in the activity modal.
Links should navigate to correct Tx URLs, or safe transactions

Original issue gnosis/cowswap#2630 by @elena-zh
@anxolin anxolin added Medium Severity indicator. It causes some undesirable behavior, but the system is still functional app:CowSwap CowSwap app Bug Something isn't working labels Apr 2, 2022
This was referenced Apr 4, 2022
Closed
Merged
@alfetopito alfetopito self-assigned this Apr 22, 2022
@elena-zh elena-zh mentioned this issue Apr 22, 2022
Merged
@alfetopito alfetopito mentioned this issue Apr 22, 2022
Closed
@elena-zh elena-zh mentioned this issue Apr 25, 2022
Merged
@W3stside W3stside mentioned this issue Apr 28, 2022
Closed
@elena-zh elena-zh closed this as completed May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alfetopito alfetopito

Labels
app:CowSwap CowSwap app Bug Something isn't working Medium Severity indicator. It causes some undesirable behavior, but the system is still functional
Projects
None yet
Milestone
No milestone
3 participants
@alfetopito @anxolin @elena-zh