Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean dead code #232

Merged
merged 2 commits into from
Oct 9, 2024
Merged

chore: clean dead code #232

merged 2 commits into from
Oct 9, 2024

Conversation

mfw78
Copy link
Contributor

@mfw78 mfw78 commented Oct 9, 2024

Description

This PR removes extraneous TypeScript that has been left over as a result of the E2E tests.

Test Plan

  1. Confirm CI/CD green.

Related Issues

#130

@mfw78 mfw78 requested a review from fedgiac October 9, 2024 07:49
@mfw78 mfw78 self-assigned this Oct 9, 2024
@mfw78 mfw78 requested a review from a team as a code owner October 9, 2024 07:49
Copy link

socket-security bot commented Oct 9, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@jridgewell/[email protected] None 0 53.2 kB jridgewell
npm/@jridgewell/[email protected] None 0 113 kB jridgewell
npm/@sindresorhus/[email protected] None 0 40.2 kB sindresorhus
npm/@szmarczak/[email protected] None 0 6.3 kB szmarczak
npm/@tsconfig/[email protected] None 0 2.31 kB typescript-deploys
npm/@tsconfig/[email protected] None 0 2.5 kB typescript-deploys
npm/@tsconfig/[email protected] None 0 2.39 kB typescript-deploys
npm/@tsconfig/[email protected] None 0 2.45 kB typescript-deploys
npm/@types/[email protected] None 0 13.9 kB types
npm/[email protected] None 0 52.3 kB adrianheine, marijn, rreverser
npm/[email protected] None 0 49.8 kB indutny
npm/[email protected] None 0 2.63 kB ryanzim
npm/[email protected] environment, network 0 375 kB jasonsaayman
npm/[email protected] None 0 6.45 kB cwmma
npm/[email protected] None 0 6.27 kB cwmma
npm/[email protected] None 0 3.68 kB cwmma
npm/[email protected] None 0 14.5 kB cwmma
npm/[email protected] network 0 16.8 kB lukechilds
npm/[email protected] None 0 14.5 kB andyburke
npm/[email protected] None 0 4.98 kB isaacs
npm/[email protected] None 0 5.4 kB cwmma
npm/[email protected] network 0 68.1 kB lquixada
npm/[email protected] None 0 53.5 kB cwmma
npm/[email protected] None 0 3.54 kB sindresorhus
npm/[email protected] network 0 5.45 kB szmarczak
npm/[email protected] None 0 38.6 kB indutny
npm/[email protected] None 0 17.3 kB cwmma
npm/[email protected] None 0 5.69 kB sindresorhus
npm/[email protected] None 0 131 kB holgerd77
npm/[email protected] network 0 26.5 kB rubenverborgh
npm/[email protected] filesystem, network 0 43.4 kB niftylettuce
npm/[email protected] filesystem 0 130 kB ryanzim
npm/[email protected] filesystem 0 21.8 kB sindresorhus
npm/[email protected] filesystem, network 0 85.4 kB sindresorhus
npm/[email protected] environment, filesystem 0 28.6 kB isaacs
npm/[email protected] None 0 18.4 kB ljharb
npm/[email protected] None 0 3.89 kB juliangruber
npm/[email protected] None 0 5.44 kB dominictarr
npm/[email protected] filesystem 0 19.8 kB ryanzim
npm/[email protected] None 0 754 kB fanatid
npm/[email protected] None 0 14.7 kB lukechilds
npm/[email protected] network 0 162 kB node-fetch-bot
npm/[email protected] None 0 18.1 kB sindresorhus
npm/[email protected] network 0 7.5 MB juancaicedo
npm/[email protected] None 0 12.5 kB sindresorhus
npm/[email protected] None 0 13 kB cwmma
npm/[email protected] None 0 2.98 kB sindresorhus
npm/[email protected] None 0 3.17 kB cwmma
npm/[email protected] None 0 27.8 kB cwmma
npm/[email protected] None 0 204 kB ljharb
npm/[email protected] None 0 6.84 kB cwmma
npm/[email protected] environment 0 88.1 kB matteo.collina
npm/[email protected] None 0 4.63 kB lukechilds
npm/[email protected] None 0 15.3 kB matteo.collina
npm/[email protected] None 0 2.79 kB sindresorhus
npm/[email protected] environment, filesystem, unsafe 0 757 kB blakeembrey
npm/[email protected] None 0 175 kB dchest
npm/[email protected] None 0 111 kB jashkenas
npm/[email protected] None 0 4.64 kB ryanzim
npm/[email protected] None 0 4.23 kB sindresorhus
npm/[email protected] None 0 34.3 kB ctavan
npm/[email protected] None 0 8.62 kB ralxz
npm/[email protected] None 0 36.8 kB ralxz
npm/[email protected] None 0 38 kB ralxz
npm/[email protected] None 0 4.77 kB ralxz
npm/[email protected] None 0 20.2 kB ralxz
npm/[email protected] None 0 20.4 kB ralxz
npm/[email protected] None 0 19.2 kB ralxz
npm/[email protected] None 0 35.9 kB ralxz
npm/[email protected] None 0 32.7 kB ralxz
npm/[email protected] None 0 46.4 kB ralxz
npm/[email protected] None 0 87.9 kB ralxz
npm/[email protected] None 0 15.1 kB ralxz
npm/[email protected] None 0 15.3 kB ralxz
npm/[email protected] None 0 60.4 kB ralxz
npm/[email protected] None 0 7.68 kB ralxz
npm/[email protected] network 0 10.9 kB ralxz
npm/[email protected] None 0 14.2 kB ralxz
npm/[email protected] None 0 19.6 kB ralxz
npm/[email protected] None 0 20.8 kB ralxz
npm/[email protected] None 0 122 kB ralxz
npm/[email protected] filesystem 0 8.52 MB ralxz
npm/[email protected] network 0 153 kB theturtle32
npm/[email protected] None 0 23.1 kB mislav
npm/[email protected] None 0 32 kB ljharb
npm/[email protected] network 0 113 kB lpinca
npm/[email protected] network 0 54.6 kB souldreamer

🚮 Removed packages: npm/@ethereumjs/[email protected], npm/@ethereumjs/[email protected], npm/@gnosis.pm/[email protected], npm/@jridgewell/[email protected], npm/@jridgewell/[email protected], npm/@safe-global/[email protected], npm/@safe-global/[email protected], npm/@safe-global/[email protected], npm/@safe-global/[email protected], npm/@sindresorhus/[email protected], npm/@slack/[email protected], npm/@slack/[email protected], npm/@slack/[email protected], npm/@szmarczak/[email protected], npm/@tsconfig/[email protected], npm/@tsconfig/[email protected], npm/@tsconfig/[email protected], npm/@tsconfig/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

Copy link

socket-security bot commented Oct 9, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Critical CVE npm/[email protected] ⚠︎

View full report↗︎

Next steps

What is a critical CVE?

Contains a Critical Common Vulnerability and Exposure (CVE).

Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@mfw78 mfw78 removed the request for review from fedgiac October 9, 2024 08:04
@mfw78
Copy link
Contributor Author

mfw78 commented Oct 9, 2024

Going to merge this into the E2E migration branch without approval as this is a staging branch prior to merge to main, and this includes missing TS that could have been cleaned out as a function of the E2E tests being migrated to foundry.

@mfw78 mfw78 merged commit 521c551 into e2e-migration Oct 9, 2024
5 checks passed
@mfw78 mfw78 deleted the clear-dead-code branch October 9, 2024 08:05
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant