Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests(e2e): balancerSwap #133

Closed
Tracked by #106
mfw78 opened this issue Jun 4, 2024 · 4 comments · Fixed by #224
Closed
Tracked by #106

tests(e2e): balancerSwap #133

mfw78 opened this issue Jun 4, 2024 · 4 comments · Fixed by #224
Labels
E:5.2 Contracts migrations See https://github.com/cowprotocol/pm/issues/32 for details help wanted Extra attention is needed test Issue related to the test suite with no expected consequence to production code

Comments

@mfw78
Copy link
Contributor

mfw78 commented Jun 4, 2024 •
edited
Loading

May be implemented as a fork test.
@mfw78 mfw78 mentioned this issue Jun 4, 2024
Open
37 tasks
@mfw78 mfw78 added help wanted Extra attention is needed test Issue related to the test suite with no expected consequence to production code E:5.2 Contracts migrations See https://github.com/cowprotocol/pm/issues/32 for details labels Jun 4, 2024
@MukulKolpe
Copy link

Hey @mfw78, can I work on this one?

@mfw78
Copy link
Contributor Author

mfw78 commented Jun 19, 2024

Sure, if you wish. Please actively ensure you are rebasing on main regularly as there are many commits coming in 🙂

@mfw78
Copy link
Contributor Author

mfw78 commented Jul 26, 2024

@MukulKolpe is there any update to this?

@mfw78 mfw78 changed the title tests(core): balancerSwap tests(e2e): balancerSwap Aug 12, 2024
@meetmangukiya meetmangukiya mentioned this issue Sep 15, 2024
Merged
mfw78 pushed a commit that referenced this issue Oct 9, 2024
@meetmangukiya
chore: migrate E2E balancerSwap test to Foundry (#224)
92ae3b5 
## Description

Migrate the balancerSwap e2e test to foundry. Depends on
#215.

## Test Plan

CI

## Related Issues

Closes #133
@mfw78
Copy link
Contributor Author

mfw78 commented Oct 9, 2024

Closed by #224

@mfw78 mfw78 closed this as completed Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E:5.2 Contracts migrations See https://github.com/cowprotocol/pm/issues/32 for details help wanted Extra attention is needed test Issue related to the test suite with no expected consequence to production code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: migrate E2E balancerSwap test to Foundry meetmangukiya/cow-core-contracts
2 participants
@mfw78 @MukulKolpe