Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor changes to fix precommit post-9.7 merge #228

Merged
merged 4 commits into from
Oct 10, 2024

Conversation

magibney
Copy link
Collaborator

No description provided.

@magibney magibney changed the title disable float precision warning (jdk11 vs 21 differs) minor changes to fix precommit post-9.7 merge Oct 10, 2024
Copy link
Collaborator

@hiteshk25 hiteshk25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@magibney magibney merged commit 4fbebe8 into fs/branch_9x Oct 10, 2024
6 of 7 checks passed
magibney added a commit that referenced this pull request Oct 10, 2024
* disable float precision warning (jdk11 vs 21 differs)
* also remove vestigial local dependency on commons-io from solrj-streaming
* precommit (required status) should run on all branches
* revert check->precommit name (to align w/ required status name -- easiest to do this way)

(cherry picked from commit 4fbebe8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants