Flowise: Add ability to connect to PostgreSQL using SSL #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IgorMilavec
reviewed
Jun 19, 2024
| @@ -101,6 +101,8 @@ spec: | |||
| key: {{ include "flowise.postgresql.secretKeyPassword" . }} | |||
| - name: POSTGRESQL_DATABASE | |||
| value: {{ include "flowise.postgresql.database" . | quote }} | |||
| - name: POSTGRESQL_SSL | |||
| value: {{ include "flowise.postgresql.ssl" . | lower }} | |||
There was a problem hiding this comment.
I think you need to add to _helpers.tpl:
{{/*
PostgreSQL ssl
*/}}
{{- define "flowise.postgresql.ssl" -}}
{{- if .Values.postgresql.enabled -}}
false
{{- else -}}
{{ .Values.externalPostgresql.ssl }}
{{- end -}}
{{- end -}}
There was a problem hiding this comment.
the "enabled = false" value should actually be disable. Or more likely the actual default value in values.yaml should be set to disable instead of false so it's more in line with the actual values postgres expects.
only "require" (default), "verify-full", "verify-ca", and "disable" supported
IgorMilavec
reviewed
Jun 19, 2024
| @@ -86,7 +86,7 @@ spec: | |||
| - /bin/sh | |||
| - -ec | |||
| - | | |||
| wait4x postgresql "postgres://${POSTGRESQL_USERNAME}:${POSTGRESQL_PASSWORD}@${POSTGRESQL_HOST}:${POSTGRESQL_PORT}/${POSTGRESQL_DATABASE}?sslmode=disable" --timeout 0 | |||
| wait4x postgresql "postgres://${POSTGRESQL_USERNAME}:${POSTGRESQL_PASSWORD}@${POSTGRESQL_HOST}:${POSTGRESQL_PORT}/${POSTGRESQL_DATABASE}?sslmode=${POSTGRESQL_SSL}" --timeout 0 | |||
There was a problem hiding this comment.
As per https://www.postgresql.org/docs/current/libpq-ssl.html I'm not sure a simple true/false will work here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example branch for PostgreSQL SSL support. See linked issue.