Feature Lambda buckets & ECS tags #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is intended to support using the terraform as a primary deployment tool for the application into different environments. By default stub code is pushed into s3 but if the `tfvars` are specified then the lambdas will honor that revised code ultimately allowing us to version the `tfvars` file as part of our deployments. The goal is to provide a reproducible snapshot of any environment using the `tfvars` file.
This allows the tfvars to become an environment's source of truth.
|
/cc @dgonzalez |
stevenbower
force-pushed
the
feature-lambda-buckets
branch
from
7f38f1a to
2b1abf8
Compare
dgonzalez
reviewed
Aug 11, 2020
| callback_lambda_s3_bucket = "" | ||
| callback_lambda_s3_key = "" | ||
| cso_lambda_s3_bucket = "" | ||
| cso_lambda_s3_key = "" |
There was a problem hiding this comment.
agreed on a call about naming:
lambda_cso_s3_key
dgonzalez
approved these changes
Aug 11, 2020
|
Pending small cosmetic change but pretty good! |
…pecific variables
pmcgrath
reviewed
Aug 12, 2020
ecs_api.tf
Outdated
| @@ -93,9 +93,10 @@ data "template_file" "api_service_container_definitions" { | |||
| template = file("templates/api_service_task_definition.tpl") | |||
|
|
|||
| vars = { | |||
| api_image_uri = "${aws_ecr_repository.api.repository_url}:latest" | |||
| api_image_uri = "${aws_ecr_repository.api.repository_url}:${var.api_container_tag}" | |||
There was a problem hiding this comment.
@segfault Guessing this is a redundant line ?
Can we change the container in the var names to image ?
Is the idea that you could set the migrations_image_repo_url ? If so will the created ECR repos be ignored if you use a different image registry ?
pmcgrath
reviewed
Aug 12, 2020
| @@ -0,0 +1,18 @@ | |||
| resource "aws_s3_bucket" "lambdas" { | |||
| bucket = module.labels.id | |||
There was a problem hiding this comment.
Not sure about this name - should we have a suffix
|
redoing this against the current repo based on the feedback |
dgonzalez
pushed a commit
that referenced
this pull request
Aug 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support using
tfvarsas an environment state snapshot in our deploy tooling we need to have the terraform honor specific settings. This changes the default lambda behavior which uploads stubs over to one that supports the original workflow and one where the deployable is explicitly specified. The same behavior and intent exists on the ECS side.This is one possible deployment workflow, but it should work for any existing environments with zero friction.