Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/deploy error #213

Merged
merged 3 commits into from
Aug 21, 2021
Merged

fix/deploy error #213

merged 3 commits into from
Aug 21, 2021

Conversation

new5558
Copy link
Member

@new5558 new5558 commented Aug 20, 2021 •
edited
Loading

Ready for review and merge
image

  • Used forked version of joi-extract-type (Original version is not supported Joi 16+)
  • For further projects, consider using other libraries for example zod since Joi has no first-class support for auto-generated typing

@new5558 new5558 merged commit 7d10468 into staging Aug 21, 2021
@new5558 new5558 deleted the fix/deploy-error branch September 15, 2021 17:58
palsp pushed a commit that referenced this pull request Sep 16, 2021
@new5558
Merge pull request #213 from palsp/fix/deploy-error
a04ca26 
fix/deploy error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palsp palsp palsp approved these changes

@guynawapas guynawapas Awaiting requested review from guynawapas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@new5558 @palsp