Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with generated code for excluded methods #1542

Conversation

daveMueller
Copy link
Collaborator

@daveMueller daveMueller commented Oct 16, 2023

closes #1484, closes #1431, closes #1547, closes #1548

@daveMueller daveMueller force-pushed the 1484_ExcludeFromCoverageSynthesizedNames branch from e02e2e4 to 585eed2 Compare October 21, 2023 22:59
@daveMueller
Copy link
Collaborator Author

This is now ready for review. Thanks @jakubch1 for the idea with the improved algorithm.

@daveMueller daveMueller marked this pull request as ready for review October 21, 2023 23:14
@daveMueller
Copy link
Collaborator Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@daveMueller daveMueller force-pushed the 1484_ExcludeFromCoverageSynthesizedNames branch from 7e410cc to f429f16 Compare October 26, 2023 08:34
@Bertk Bertk self-requested a review November 11, 2023 10:50
Copy link
Collaborator

@Bertk Bertk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daveMueller daveMueller merged commit c69d37e into coverlet-coverage:master Nov 19, 2023
8 checks passed
@daveMueller daveMueller deleted the 1484_ExcludeFromCoverageSynthesizedNames branch November 19, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment