-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with generated code for excluded methods #1542
Merged
daveMueller
merged 7 commits into
coverlet-coverage:master
from
daveMueller:1484_ExcludeFromCoverageSynthesizedNames
Nov 19, 2023
Merged
Issue with generated code for excluded methods #1542
daveMueller
merged 7 commits into
coverlet-coverage:master
from
daveMueller:1484_ExcludeFromCoverageSynthesizedNames
Nov 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daveMueller
force-pushed
the
1484_ExcludeFromCoverageSynthesizedNames
branch
from
October 21, 2023 22:59
e02e2e4
to
585eed2
Compare
This is now ready for review. Thanks @jakubch1 for the idea with the improved algorithm. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
daveMueller
force-pushed
the
1484_ExcludeFromCoverageSynthesizedNames
branch
from
October 26, 2023 08:34
7e410cc
to
f429f16
Compare
Bertk
approved these changes
Nov 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Bertk
approved these changes
Nov 13, 2023
Bertk
approved these changes
Nov 17, 2023
MarcoRossignoli
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1484, closes #1431, closes #1547, closes #1548