-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
coverlet.msbuild.tasks unit tests #1534
coverlet.msbuild.tasks unit tests #1534
Conversation
Bertk
commented
Sep 15, 2023
•
edited
Loading
edited
- add CoverageResultTaskTests.cs for coverlet.msbuild.tasks unit test
- allows local debugging of msbuild tasks
- removes system.console output in ReportWriter (potential conflicts - msbuild task logging)
e54a9d7
to
5eb82d9
Compare
4802104
to
0a9bcb8
Compare
8e5fcf7
to
3470492
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see formatting and updates, maybe it's better avoid to format here and add only tests to make the review easier, we could lose some small detail
This is will be fixed with the other PR #1529 . The source code files are not in sync with the current definitions of |
9439e95
to
56b3369
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM wait for @daveMueller green light
@daveMueller By the way, could you please check whether mandatory checks are defined? Otherwise a PR with a broken build pipeline could be merged. This configuration is available in Settings->branches->branch protection |
Sorry I also don't have permission to look into that. Maybe @MarcoRossignoli can? But I'm pretty sure that PRs with a failed build job can't be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @Bertk 🙏