Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NOMERGE]Relative paths lcov #1120

Conversation

phaniva
Copy link

@phaniva phaniva commented Mar 9, 2021

No description provided.

@phaniva phaniva mentioned this pull request Mar 9, 2021
@MarcoRossignoli MarcoRossignoli added the tenet-coverage Issue related to possible incorrect coverage label Mar 9, 2021
@MarcoRossignoli
Copy link
Collaborator

Thanks @phaniva I'll wait to merge this one because I think it's better let to user decide if use or not relative path in reports.
There are some security concerns on it so shouldn't be the default.
As soon as this guy #1113 will be merged we'll add new parameter like --useRelativePathsReport or something like that to drive report creation.

cc: @daveMueller

@MarcoRossignoli MarcoRossignoli changed the title Relative paths lcov [NOMERGE]Relative paths lcov Mar 9, 2021
@phaniva
Copy link
Author

phaniva commented Apr 19, 2021

@MarcoRossignoli Any idea on how to debug the above failure? The error message appears to indicate some failure reading a csproj file. Is there way to kick off the pipeline one more time?

@MarcoRossignoli
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@MarcoRossignoli
Copy link
Collaborator

@phaniva can you open an issue for this one?
Can you explain your scenario and why you need relative path?
Can you point me to some docs related to lcov relative path support for reports generators?

@phaniva
Copy link
Author

phaniva commented Oct 30, 2021

@MarcoRossignoli This PR is for addressing the issue 263
This is for addressing issues where coverage reports are generated in one place and the reports are viewed in another place.

Copy link

@Juancanico5 Juancanico5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarcoRossignoli
Copy link
Collaborator

There're some conflicts we can give it a try if someone solve it, we need anyway to do a review too cc: @daveMueller @Bertk

@Bertk Bertk added the stale label Apr 9, 2024
@Bertk
Copy link
Collaborator

Bertk commented Apr 9, 2024

This PR was closed because it is outdated.

@Bertk Bertk closed this Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale tenet-coverage Issue related to possible incorrect coverage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants