-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Threshold not fail when no module #1115
Threshold not fail when no module #1115
Conversation
371cbba
to
89600ac
Compare
An output like the following
currently only happens when for what ever reason the There are two solution I can think of. One would throw an exception. Something like "No coverage could be calculated because the result doesn't contain any modules." However this might break some CI pipelines just because coverage has an issue. The other solution would be to return a coverage of 0 when this happens. This is what I prepared in this PR. But personally I'm a bit divided about this. What do you think, @MarcoRossignoli @martincostello ? |
Yeah I think 0% is better, as then the coverage threshold will take effect if it's configured and fail the build that way. |
I agree with Martin, go for 0% and fail if there is a threshold check. Thx Dave. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@daveMueller remember to update the changelog thx a lot! |
closes #1083