Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multi-line lambda coverage regression #1060

Merged

Conversation

MarcoRossignoli
Copy link
Collaborator

@MarcoRossignoli MarcoRossignoli commented Jan 17, 2021

closes #1056

Before

before

After

image

cc: @ulrichb @daveMueller

@MarcoRossignoli
Copy link
Collaborator Author

MarcoRossignoli commented Jan 17, 2021

The overlapped lambda accounting is not correct yet...I have some working that fix it but I need to work more on it because there is an ambiguity with C# switch pattern and I'm trying to understand how to solve.
BTW is not a regression it's always been incorrect.

@MarcoRossignoli MarcoRossignoli added bug Something isn't working tenet-coverage Issue related to possible incorrect coverage labels Jan 17, 2021
@MarcoRossignoli MarcoRossignoli merged commit 070f2b4 into coverlet-coverage:master Jan 17, 2021
@MarcoRossignoli MarcoRossignoli deleted the fixmultilinelambda branch January 17, 2021 18:44
@SebastienPortier
Copy link

Hi !

Thanks for release, the situation is improving on multi lines lambda 👍 . Coverage is ok when having one lambda on multi line, but when chaining multiple lambdas (for example in Fluent synthax way), coverage has still some holes :

One line is OK
Capture d’écran 2021-01-25 122008

One lambda chained multiple line is OK
Capture d’écran 2021-01-25 122149

Multiple lambdas chained multiple lines is KO
Capture d’écran 2021-01-25 122132

@MarcoRossignoli
Copy link
Collaborator Author

@SebastienPortier can you open another issue pls?
Is this a regression from 2.9.0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tenet-coverage Issue related to possible incorrect coverage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi-line lambda false negatives in 3.0.1
2 participants