Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow empty coverage for cobertura #43

Merged
merged 2 commits into from
Mar 23, 2023
Merged

fix: allow empty coverage for cobertura #43

merged 2 commits into from
Mar 23, 2023

Conversation

mrexox
Copy link
Contributor

@mrexox mrexox commented Mar 23, 2023

⚡ Summary

Cobertura can contain empty results. In this case we shouldn't raise an error

☑️ Checklist

  • Use max? instead of max
  • Fixed a fixture to check that no errors are returned

@coveralls
Copy link
Member

Coverage Status

Coverage: 89.801% (-0.3%) from 90.146% when pulling 4ee2596 on mrexox:fix/allow-empty-coverage-for-cobertura into 411e123 on coverallsapp:master.

@mrexox mrexox merged commit 8a6ea39 into coverallsapp:master Mar 23, 2023
@mrexox mrexox deleted the fix/allow-empty-coverage-for-cobertura branch March 23, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrexox @coveralls