Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify Makefile to fix issues with sed handling inputs. #139

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

afinetooth
Copy link
Member

@afinetooth afinetooth commented Aug 13, 2024

⚡ Summary

  • Modify Makefile to fix issues with sed handling inputs.
  • Prior to changes, make new_version was throwing errors like this:
% make new_version
New version: 0.6.13
Brief description: Update Crystal lang version to 1.13.1
sed -i "s/version:.*/version: $version/" shard.yml
sed: 1: "shard.yml": unterminated substitute pattern
make: *** [new_version] Error 1

☑️ Checklist

  • Modify Makefile 🤞

Copy link

coveralls-official bot commented Aug 13, 2024

Pull Request Test Coverage Report for Build 10361837899

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 94.087%

Totals Coverage Status
Change from base Build 10361166725: 0.1%
Covered Lines: 907
Relevant Lines: 964

💛 - Coveralls

@afinetooth afinetooth merged commit 9057b0b into master Aug 13, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant